Skip to content

Conversation

@Praneel-Shivarkar
Copy link

@Praneel-Shivarkar Praneel-Shivarkar commented Oct 25, 2025

Problem Statement: Given sequence k = k1 <k2 < … <kn of n sorted keys, with a search probability pi for each key ki . Build the Binary search tree that has the least search cost given the access probability for each key?

Summary by Sourcery

New Features:

  • Implement OBST algorithm in C++ to build an optimal binary search tree from key access probabilities

Implement Optimal Binary Search Tree algorithm.
@sourcery-ai
Copy link

sourcery-ai bot commented Oct 25, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This PR adds a C++ implementation of the optimal binary search tree algorithm, using dynamic programming to compute minimal search costs and reconstruct the tree structure from computed root indices.

File-Level Changes

Change Details Files
Implemented dynamic programming solution for OBST
  • Initialize weight (w), cost (e) and root matrices
  • Compute w and e tables in increasing subtree length order
  • Track optimal root positions in root matrix
OBST_DSA
Reconstruct and display the optimal BST
  • Implement recursive function to build and print tree structure
  • Format output to show parent-child relationships
OBST_DSA
Set up input handling and output reporting
  • Read number of keys and their probabilities
  • Invoke OBST computation and print total cost
OBST_DSA

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for raising the PR, the owner will be review it soon' keep patience, keep contributing>>>!!! make sure you have star ⭐ the repo

@SjxSubham
Copy link
Owner

@Praneel-Shivarkar raise an ISSUE as well regarding the problem

@Praneel-Shivarkar
Copy link
Author

@SjxSubham can you please merge this?

@SjxSubham
Copy link
Owner

@Praneel-Shivarkar no need to be hurry...make these changes

  1. Chnage PR name/Title
  2. maintain Proper PR description format.
  3. Star the repo

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change file name ...
rename the file name as ProblemNo. PRoblem Name.cpp

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Praneel-Shivarkar after this above changes I'll merge ur PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants